Skip to content

Update to ACK runtime v0.56.0, code-generator v0.56.0 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

Update to ACK runtime v0.56.0, code-generator v0.56.0 #87

merged 1 commit into from
Nov 29, 2025

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0

NOTE:
This PR increments the release version of service controller from v1.2.2 to v1.3.0

Once this PR is merged, release v1.3.0 will be automatically created for kafka-controller

Please close this PR, if you do not want the new patch release for kafka-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building kafka-controller ====
Copying common custom resource definitions into kafka
Building Kubernetes API objects for kafka
Generating deepcopy code for kafka
Generating custom resource definitions for kafka
Building service controller for kafka
Running GO mod tidy
Generating RBAC manifests for kafka
Running gofmt against generated code for kafka
Updating additional GitHub repository maintenance files
==== building kafka-controller release artifacts ====
Building release artifacts for kafka-v1.3.0
Generating common custom resource definitions
Generating custom resource definitions for kafka
Generating RBAC manifests for kafka

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler November 29, 2025 03:33
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2025
View reviewed changes
.github/workflows/postsubmit.yaml

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 6 days ago

To fix this problem, add a permissions block at the workflow root level (before the jobs: key) in .github/workflows/postsubmit.yaml. If you do not know the precise permissions required by the called workflow (aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml), start with a secure default of contents: read (which is the least privilege required for most workflows), and adapt as needed when requirements become clearer. This approach ensures that inherited permissions do not unintentionally allow write access to all repository resources. Insert these lines after the workflow name: and before the on: section (to match common workflow syntax).

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,5 +1,8 @@
 name: Hydrate Go Proxy
 
+permissions:
+  contents: read
+
 on:
   push:
     branches:
EOF
@@ -1,5 +1,8 @@
name: Hydrate Go Proxy

permissions:
contents: read

on:
push:
branches:
Copilot is powered by AI and may make mistakes. Always verify output.
@a-hilaly
Copy link
Member

a-hilaly commented Nov 29, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025 •
edited
Loading

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kafka-verify-code-gen 1cf3ba7 link false /test kafka-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

a-hilaly commented Nov 29, 2025

/test kafka-kind-e2e

@ack-prow ack-prow bot merged commit 2c5f42c into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ack-bot @a-hilaly